Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh colormapping fixes #1484

Merged
merged 4 commits into from May 31, 2017
Merged

Bokeh colormapping fixes #1484

merged 4 commits into from May 31, 2017

Conversation

philippjfr
Copy link
Member

Two colormapping fixes the first fixes a bug in assigning colors to Bars in the right order, the second allows passing a list of colors to bokeh instead of a matplotlib colormap which should always have been allowed.

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label May 25, 2017
@philippjfr
Copy link
Member Author

philippjfr commented May 29, 2017

This PR now adds support for supplying explicit lists of colors as cmaps and selecting some of the inbuilt bokeh palettes as strings. In doing this I discovered that using bokeh palettes is not sufficient, they contain at most 11 colors and do not interpolate between the colors which is not very nice for continuous values. This means for the time being we still rely on the colormaps shipped with matplotlib. I see a number of solutions:

  1. Add code to interpolate between colors and generate larger colormaps on the fly, the base colors for each colormap would still have to come from somewhere though.
  2. Require colorcet and only offer the colormaps it includes unless matplotlib is installed.
  3. Ship a few colormaps ourselves.

@jbednar @jlstevens We don't have to resolve this immediately but we should decide what to do.

@jlstevens
Copy link
Contributor

Ready to merge? I would consider putting your question about colormaps into an issue and assigning it to the 1.8 milestone.

@philippjfr
Copy link
Member Author

I would consider putting your question about colormaps into an issue and assigning it to the 1.8 milestone.

Sounds like a plan. Yes this can be merged.

@jlstevens jlstevens merged commit 12b0815 into master May 31, 2017
@philippjfr philippjfr deleted the bokeh_colormapping_fixes branch June 17, 2017 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants