Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invert_axes for all Element types #1919

Merged
merged 12 commits into from Oct 7, 2017
Merged

Handle invert_axes for all Element types #1919

merged 12 commits into from Oct 7, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 24, 2017

We never implemented invert_axes for all Element types. This code does that ensuring that any plot can now be adjoined.

Fixes:

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 25, 2017

Looks good although I was hoping to see cruft removed with a replacement at the level of ElementPlot or some such base class.

Happy to merge once the tests pass, ideally with a few new unit tests.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Sep 25, 2017

This is not ready to review or merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 25, 2017

This is not ready to review or merge.

I know! Which is why I kept my comments general and checked you hadn't added the WIP tag (yet).

@philippjfr philippjfr force-pushed the mpl_invert_axes branch from d7c0451 to d951392 Oct 6, 2017
@philippjfr philippjfr force-pushed the mpl_invert_axes branch from d951392 to eac70d7 Oct 6, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Oct 6, 2017

Looks good although I was hoping to see cruft removed with a replacement at the level of ElementPlot or some such base class.

Not really possible, a baseclass can't know how to properly invert the data for a particular Element.

@philippjfr philippjfr force-pushed the mpl_invert_axes branch from f747d70 to 2c39810 Oct 6, 2017
@philippjfr philippjfr force-pushed the mpl_invert_axes branch from 2c39810 to 5e85b93 Oct 6, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Oct 7, 2017

Ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 7, 2017

I'll merge though I do have one question.

Not really possible, a baseclass can't know how to properly invert the data for a particular Element.

Perhaps this could be made easy at the data API level?

@jlstevens jlstevens merged commit 3b11689 into master Oct 7, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 79.913%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Oct 7, 2017

If it was just about invert_axes I'd definitely agree with you, but in many cases it's tied up with the code to invert_xaxis and invert_yaxis, which definitely isn't a data API level concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants