Fix bokeh SideHistogram colormapper CustomJS #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
|
I tested this change and it did fix the errors I was seeing in the web console. Happy to merge when the tests pass. |
|
Needs rebuilt test data. Should go in after: #2267 since that also changes the test data. |
jlstevens
force-pushed
the
bokeh_dynamic_hist
branch
from
4434d44
to
179dcd7
Compare
|
I've rebased off latest master and I'll update the test data once the tests finish running. |
|
@philippjfr The PR build is now passing. Ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API for triggering change events in Bokeh clientside has changed. This updates it to use the new API, since we've pinned bokeh to recent versions this is safe and has no backward compatibility implications.