Fixed plotting of QuadMesh with nan coordinates #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
|
Ready to merge. |
jlstevens
reviewed
May 21, 2018
| else: | ||
| mask.append(False) | ||
|
|
||
| data = {'xs': XS, 'ys': YS, z.name: zvals[np.array(mask)]} |
There was a problem hiding this comment.
Maybe I am misunderstanding, but why can't you just compute the mask and apply that to xs and ys instead of defining XS and YS?
There was a problem hiding this comment.
XS and YS are lists of arrays and not arrays themselves.
There was a problem hiding this comment.
To be perfectly accurate they are lists of lists since the overhead for serializing and deserializing a bunch of tiny arrays is much larger than any benefit gained.
|
Looks fine. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that curvilinear coordinate meshes are all valid before plotting. Useful when plotting projected QuadMesh with some invalid values.