Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contours operation to work with QuadMesh #2702

Merged
merged 2 commits into from May 21, 2018
Merged

Update contours operation to work with QuadMesh #2702

merged 2 commits into from May 21, 2018

Conversation

philippjfr
Copy link
Member

The contours operation had not been updated to work with the new Dataset based QuadMesh API.

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label May 19, 2018
@jlstevens
Copy link
Contributor

Maybe worth adding a unit test?

@philippjfr
Copy link
Member Author

Done, ready to merge when passing.

@jlstevens
Copy link
Contributor

Looks good. Merging.

@jlstevens jlstevens merged commit 234a3e4 into master May 21, 2018
@philippjfr philippjfr deleted the fix_qmesh_contours branch July 4, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philippjfr @jlstevens