Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Interface improvements #2767

Merged
merged 5 commits into from Jun 4, 2018
Merged

Minor Interface improvements #2767

merged 5 commits into from Jun 4, 2018

Conversation

philippjfr
Copy link
Member

Three minor fixes/improvements for data interfaces:

  1. Fixed pandas 0.23 deprecation warning in rolling operation
  2. Added element conversion method for violin (Fixes ds.to.violin doesn't exist, but holoplot has it #2763)
  3. Filter warnings for nan/inf comparisons on Interface.select_mask

@philippjfr philippjfr added tag: component: data type: enhancement Minor feature or improvement to an existing feature labels Jun 4, 2018
@philippjfr
Copy link
Member Author

Ready to merge once tests are passing.

@jlstevens
Copy link
Contributor

Tests are green and the changes look good. Merging.

@jlstevens jlstevens merged commit 2e7ac9a into master Jun 4, 2018
@philippjfr philippjfr deleted the interface_improvements branch July 4, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tag: component: data type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ds.to.violin doesn't exist, but holoplot has it
2 participants
@philippjfr @jlstevens