Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all tests pass without pandas, dask, xarray and scipy #3453

Merged
merged 13 commits into from
Feb 3, 2019

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 3, 2019

As the title says, ensuring the tests match mostly means ensuring that datetimes are handled more consistently. This also uncovered a number of pretty nasty bugs.

  • Dropping a kdim on a non-scalar gridded dataset was broken without pandas
  • The DictInterface always added an index to an 1D array (instead of respecting auto_indexable_1d)
  • Datetime and Date times were not handled as scalars
  • Without pandas but with dask the DaskInterface would still accept input but raise an exception when dask.dataframe is imported (fixes DaskInterface is used even though pandas is not installed #3430)
  • Image.sample did not work at all without pandas
  • Plot padding was broken for datetimes where the axis range was close to the date resolution

Otherwise I updated all tests to appropriately skip if a dependency was not available.

@philippjfr philippjfr changed the title Ensure all tests pass with pandas, dask, xarray and scipy Ensure all tests pass without pandas, dask, xarray and scipy Feb 3, 2019
@jlstevens
Copy link
Contributor

Thanks for doing this. I'm not surprised that bugs were uncovered having tried to run the tests without all the dependencies in the past.

How do we make sure tests keep working properly using only core dependencies given we want to test as much as possible on travis (and therefore install as much as possible)?

@philippjfr
Copy link
Member Author

I'll add a cron job for this in the other PR.

@philippjfr philippjfr merged commit 3427e10 into master Feb 3, 2019
@philippjfr philippjfr deleted the test_fixs branch April 29, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DaskInterface is used even though pandas is not installed
2 participants