Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tiles element from geoviews #3515

Merged
merged 11 commits into from Feb 22, 2019
Merged

Added Tiles element from geoviews #3515

merged 11 commits into from Feb 22, 2019

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 21, 2019

No description provided.

@philippjfr philippjfr force-pushed the tiles_element branch 2 times, most recently from 9741fbb to d650e4a Feb 21, 2019
Copy link
Member

@jbednar jbednar left a comment

Looks great to me!

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 21, 2019

Looks good.

I didn't know you were working on this so I started working on a PR with the same goal - it looks you beat me to it as I was doing exactly the same thing!

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 22, 2019

Happy to see this merged when the tests pass.

@philippjfr philippjfr force-pushed the tiles_element branch from b79a6ac to b289a54 Feb 22, 2019
Copy link
Member

@jbednar jbednar left a comment

Looks great; happy to see it merged!

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 22, 2019

Tests are green before the docstring fixes (except for appveyor which passed on the next commit). Merging.

@jlstevens jlstevens merged commit e3b3d4d into master Feb 22, 2019
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage decreased (-0.09%) to 90.177%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the tiles_element branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants