Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CuDF Series is not iterable #4624

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

bryevdv
Copy link
Member

@bryevdv bryevdv commented Sep 21, 2020

@philippjfr This is a fix for https://github.com/holoviz/hvplot/issues/510 (which should probably be copied to this repo)

Summary: .unique() returns a CuDF Series, which is not iterable unless copied to host.

No tests as of yet (looking in to GPU CI options)

@jlstevens
Copy link
Contributor

Looks good to me!

@philippjfr
Copy link
Member

Let's go ahead and merge and then find a solution for GPU CI later. Before a 1.13.5 I or someone else should run the test suite against latest cuDF again.

@philippjfr philippjfr merged commit d67e2c5 into holoviz:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants