Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated operation streams parameter definitions #4825

Merged
merged 1 commit into from Feb 9, 2021

Conversation

jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 8, 2021

Running the Large Data notebook on current master revealed a param bug (holoviz/param#455) where decimate was failing despite having a valid declaration.

The issue is that #4818 generalized the allowable values for the streams parameter but the param bug referenced above means that all operations need to use the same ClassSelector definition even if the current declaration is a valid subset of what is accepted by the base class (i.e param.List or param.Dict).

I realize that I probably updated a bunch of parameter definitions in #4818 even though it wasn't strictly necessary (if the param bug wasn't an issue).

It is important to fix this param issue as all user defined operations will also be affected: users shouldn't have to update their streams parameter definitions.

@jlstevens
Copy link
Contributor Author

@philippjfr I've grepped for streams definitions everywhere and can't see any more operations that need updating. Happy to merge?

@philippjfr philippjfr merged commit f100379 into master Feb 9, 2021
@philippjfr philippjfr deleted the streams_parameter_declaration_fix branch April 25, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants