Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set plotly range correctly for log axis #5272

Merged
merged 1 commit into from Apr 14, 2022

Conversation

pepijndevos
Copy link
Contributor

This addresses the part of #3698 where the plot bounds are set incorrectly for log axis

@codecov-commenter
Copy link

Codecov Report

Merging #5272 (7ff1619) into master (4a3ae17) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5272   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files         299      299           
  Lines       62189    62191    +2     
=======================================
+ Hits        53930    53932    +2     
  Misses       8259     8259           
Impacted Files Coverage Δ
holoviews/plotting/plotly/element.py 85.11% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3ae17...7ff1619. Read the comment docs.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; failing tests are presumably unrelated timeouts.

@philippjfr philippjfr merged commit 15adc0d into holoviz:master Apr 14, 2022
@philippjfr
Copy link
Member

Thanks @pepijndevos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants