-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed dependency on matplotlib, nbformat and pyparsing in ipython #529
Conversation
345b1de
to
f58a17a
Compare
holoviews.archive = notebook_archive | ||
except ImportError: | ||
pass | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we'll want to add some # noqa
lines here for pyflakes...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, the nbformat lines will need it.
Looks good and does what I expect. We only need jinja2 if widgets are requested and a conditional import of archive makes sense in case pyparsing is missing. |
Also used to display the
Archive only requires nbformat. It's the parser that requires pyparsing which was already mostly working except that although the magics were wrapping the import in a try except the |
Does this address the issues that Ilan found when he made conda packages for the main channel, for python3? Hopefully those extra dependencies that he found would no longer be needed? |
Yes it does, although we should still add notebook as a dependency to our conda package. |
f58a17a
to
b3ef12b
Compare
Yes, I was confusing the use of pyparsing for the magics with nbformat for archive. The conditional import still makes sense though... |
6c519c5
to
410106b
Compare
Ready to merge once the tests pass. |
Ok the tests are passing so I'll merge it now. |
Addresses issues mentioned in #528 partially by removing all hard dependencies on notebook and matplotlib in the ipython module. This ensures holoviews can be imported in IPython even without matplotlib and the notebook.