Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEP 1: Python version support #362

Merged
merged 2 commits into from
May 23, 2023
Merged

HEP 1: Python version support #362

merged 2 commits into from
May 23, 2023

Conversation

ianthomas23
Copy link
Member

This PR adds the first HoloViz Enhancement Proposal, on python version support, to the holoviz repo. It is placed in a new hep directory, and the idea is that future HEPs will be placed in the same directory and there will be one or more links from holoviz.org to them.

Rendered markdown is at https://github.com/holoviz/holoviz/blob/hep1/hep/hep1.md.

Everything here is open to discussion: the HEP itself, the format of the HEP, the directory structure, etc.

@droumis
Copy link
Member

droumis commented Apr 19, 2023

looks good. Might be good to mention this in the SC meeting next Friday April 28

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianthomas23
Copy link
Member Author

This has 2 approvals. I'll give people until Monday to express any contrary opinions, otherwise I will merge it myself.

Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document defines the policy for when a Python version should be dropped. All the HoloViz projects (attempt to) follow Semantic Versioning. I think that our convention for dropping support for a Python version was that it wouldn't happen in a patch version but at least in a minor version. Now, I'm not entirely sure that was the convention, and if it was, I'm not entirely sure we should keep following it. And really, I have no opinion on that, except that I think we should agree on what's acceptable and probably add it to that document?

hep/hep1.md Show resolved Hide resolved
@ianthomas23
Copy link
Member Author

@maximlt I'm not familiar with the (possible) convention on relating project and python versions, either within HoloViz or outside. If there is a convention going forward then yes we should add a comment or link here about it. But probably the best approach would be for the HoloViz project versioning to be documented first, e.g. in HEP2, even if it is just a single paragraph linking to standard SemVer practice.

@ianthomas23 ianthomas23 merged commit d7df504 into main May 23, 2023
3 checks passed
@ianthomas23 ianthomas23 deleted the hep1 branch May 23, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants