Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEP1 - Drop support for Python 3.7 #5695

Merged
merged 3 commits into from
Jun 22, 2023
Merged

HEP1 - Drop support for Python 3.7 #5695

merged 3 commits into from
Jun 22, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 25, 2023

With Python 3.7's end of life at the end of June and the upcoming release of Holoviews 1.17, it makes sense to have Holoviews support Python 3.8 and up.

Following: HEP1 at holoviz/holoviz#362

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #5695 (8a7523f) into main (be58b7e) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5695      +/-   ##
==========================================
- Coverage   88.16%   88.14%   -0.03%     
==========================================
  Files         307      307              
  Lines       62839    62839              
==========================================
- Hits        55405    55390      -15     
- Misses       7434     7449      +15     
Flag Coverage Δ
ui-tests 22.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
holoviews/plotting/util.py 68.78% <ø> (ø)
holoviews/tests/plotting/test_plotutils.py 97.19% <ø> (ø)
holoviews/core/data/ibis.py 76.87% <100.00%> (-4.69%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

I'd be in favor of doing this after the 1.16 release. There's no pressing need right now since we still support older versions of Bokeh/Panel.

@hoxbro
Copy link
Member Author

hoxbro commented Apr 25, 2023

The bump is not related to Bokeh/Panel going to 3.8, but that it will become much more time-consuming supporting old versions of Python, especially in the CI. Note that we will still support older versions of Bokeh/Panel with this change.

Python 3.7 is going out of life in two months and in my opinion, this is close enough to stop supporting it. If we had a more consistent release of HoloViews, a reason could be made to wait, but looking at the history of the last two minor releases, a year can easily go by. 1.15 was released on July 7, 2022, and 1.14 was released on December 3, 2020.

@hoxbro hoxbro added this to the 1.17.0 milestone May 8, 2023
@hoxbro hoxbro changed the title Drop support for Python 3.7 HEP1 - Drop support for Python 3.7 Jun 22, 2023
@hoxbro hoxbro merged commit bbebd27 into main Jun 22, 2023
@hoxbro hoxbro deleted the pin_python38 branch June 22, 2023 08:33
Reamer added a commit to Reamer/zeppelin that referenced this pull request Aug 2, 2023
Reamer added a commit to apache/zeppelin that referenced this pull request Aug 7, 2023
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants