Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrypoints for pandas >=0.25 #319

Merged
merged 10 commits into from Oct 2, 2019
Merged

Entrypoints for pandas >=0.25 #319

merged 10 commits into from Oct 2, 2019

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Sep 25, 2019

Doesn't yet return proper help or work with df.plot.scatter() style calls

EDIT: it does work with df.plot.scatter() style calls, they just have the same requirements as the df.plot versions (aka plot.scatter requires x and y to be set explicitly whereas hvplot does not).

Closes #277

Screen Shot 2019-09-25 at 11 39 47 AM

Screen Shot 2019-09-25 at 11 41 01 AM

@jsignell jsignell changed the title [WIP] Entrypoints for pandas >=0.25 Entrypoints for pandas >=0.25 Oct 1, 2019
@jsignell
Copy link
Member Author

jsignell commented Oct 1, 2019

I consider this done. There are some outstanding issues to be resolved on the pandas side. But this chunk of work should probably get in sooner rather than later.

@jsignell
Copy link
Member Author

jsignell commented Oct 1, 2019

Note that in this PR, by, groupby, and hover_cols will only work if the columns that they reference are in x or y. See pandas-dev/pandas#28647 for the full description.

@jsignell jsignell self-assigned this Oct 1, 2019
hvplot/plotting/core.py Outdated Show resolved Hide resolved
@jsignell
Copy link
Member Author

jsignell commented Oct 2, 2019

To Do:

  • make sure that there are no references to patch in the docs

@jsignell
Copy link
Member Author

jsignell commented Oct 2, 2019

I am fairly confident that the remaining error is unrelated.

@jsignell
Copy link
Member Author

jsignell commented Oct 2, 2019

I think this is ready to merge

@philippjfr philippjfr merged commit ab43c4f into master Oct 2, 2019
@jsignell jsignell deleted the jsignell/entrypoint branch October 17, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pandas.plot entrypoints style
2 participants