Skip to content

State that the data cannot be symmetric if it's empty#680

Merged
philippjfr merged 1 commit into
masterfrom
handle_empty_color_column
Nov 23, 2021
Merged

State that the data cannot be symmetric if it's empty#680
philippjfr merged 1 commit into
masterfrom
handle_empty_color_column

Conversation

@maximlt

@maximlt maximlt commented Nov 22, 2021

Copy link
Copy Markdown
Member

A RuntimeWarning was emitted by numpy with the following snippet. It was trying to calculate np.nanquantile on an empty series in this case.

import pandas as pd
import hvplot.pandas

df = pd.DataFrame({'x': [], 'y': [], 'color': []})
df.hvplot(kind='scatter', x='x', y='y', color='color')

The only thing I'm unsure of is whether the data variable always has a size parameter. In other words, what type of object could data possibly be in this function?

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 72.427% when pulling d50a52c on handle_empty_color_column into 17ce0cc on master.

@philippjfr
philippjfr merged commit 1c49113 into master Nov 23, 2021
@maximlt
maximlt deleted the handle_empty_color_column branch April 1, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants