Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State that the data cannot be symmetric if it's empty #680

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Nov 22, 2021

A RuntimeWarning was emitted by numpy with the following snippet. It was trying to calculate np.nanquantile on an empty series in this case.

import pandas as pd
import hvplot.pandas

df = pd.DataFrame({'x': [], 'y': [], 'color': []})
df.hvplot(kind='scatter', x='x', y='y', color='color')

The only thing I'm unsure of is whether the data variable always has a size parameter. In other words, what type of object could data possibly be in this function?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 72.427% when pulling d50a52c on handle_empty_color_column into 17ce0cc on master.

@philippjfr philippjfr merged commit 1c49113 into master Nov 23, 2021
@maximlt maximlt deleted the handle_empty_color_column branch April 1, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants