fix 692: add more imports to try/except import check #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test is something with wrong or missing dimensions declared? Not an issue with these changes. |
|
Hey @michaelaye thanks for this fix! hvplot's CI is currently broken due to a bug introduced in the latest version of holoviews. This bug has already been fixed but has not yet been released. I think that I'd like to make soon a dev release of holoviews, which would fix the test suite here. Once this is done, I'll rerun the test workflow on your PR to see if it passes the tests. As for your fix it looks good to me. |
|
there were some release on holoviews in the mean time, could this be merged then? It creates issues for newbies as seen in more comments on #692 . |
|
Looks good, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #692