Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Pytest and run the CI on Python 3.6, 3.8 and 3.9 #703

Merged
merged 85 commits into from
Jan 31, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jan 26, 2022

  • Run it on Py38 and Py39
  • Run it on MacOs
  • Switch to pytest
  • Switch to codecov
  • Check the tests skipped
  • Run the CI on Py36

setup.cfg Outdated Show resolved Hide resolved
@maximlt
Copy link
Member Author

maximlt commented Jan 31, 2022

I'll merge this now since the test suite finally passes:

  • on Python 3.6 I haven't been able to get conda to solve so I've had to limit the tests to execute to the unit tests, discarding the examples test (smoke test the notebooks). mamba did manage to solve (locally) so it's likely that when conda gets the libmamba solver we will be able to run the examples test again on 3.6. Funny fact, I once saw an 137 exit code while conda was solving, meaning that the container ran out of memory!
  • the main difference with how things used to work is that now the conda channels used in the whole job are configured in the setup-miniconda action, as long as with the strict channel parameter. All the later calls are then bare conda install package without any -c channel1 since they're already set.
  • Updated some projection-related code by copying it from salem (this was already the case) since the ecosystem has seen some change in this field (cartopy, pyproj)

@maximlt maximlt merged commit cf42ea2 into master Jan 31, 2022
@maximlt maximlt deleted the ci_fix_38_39 branch January 31, 2022 16:38
@maximlt maximlt changed the title Improve test workflow on GHA Switch to Pytest and run the CI on Python 3.6, 3.8 and 3.9 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants