Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application of the scale argument for geoviews features #725

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

FabianHofmann
Copy link
Contributor

When creating a figure with geo=True, the scale argument for geoviews-features is currently ignored. According to the documentation and docstrings, this should be supported via setting the feature argument to a dictionary in the form of {feature: scale}.

With this change, the scale argument is forwarded to the opts function of the geoviews feature class.

Test with

import hvplot.pandas  # noqa
from bokeh.sampledata.airport_routes import airports

plot = airports.hvplot.points(
    "Longitude",
    "Latitude",
    geo=True,
    color="red",
    alpha=0.2,
    xlim=(-180, -30),
    ylim=(0, 72),
    tiles="ESRI",
    features={"states": "10m"},
)

hvplot.show(plot)

@philippjfr
Copy link
Member

Good catch, thank you!

@philippjfr philippjfr merged commit 04c2ce9 into holoviz:master Mar 31, 2022
@FabianHofmann
Copy link
Contributor Author

@philippjfr my pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants