Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support slice in interactive #776

Merged
merged 6 commits into from
Oct 14, 2022
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jul 11, 2022

Part 2 of the solution for #771.

It needs holoviz/holoviews#5352 to work.

The panel check is removed because panel is already imported at the top. Therefore, I think the check is unnecessary, but correct me if I'm wrong.

@maximlt
Copy link
Member

maximlt commented Oct 13, 2022

test_interactive_slice is failing on Python 3.6. In these jobs the HoloViews version is 1.14.8 which doesn't yet have the fix to support slices that was added in holoviz/holoviews#5352 and made available in HoloViews 1.15.1. @hoxbro could you a guard checking HoloViews version after iff isinstance(op_arg, slice): and raising an error if it's too old, and skip that test for older HoloViews version?

@maximlt
Copy link
Member

maximlt commented Oct 14, 2022

Thanks for making these last changes!

@maximlt maximlt merged commit 6aead29 into holoviz:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants