-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the explorer easier to use #799
Conversation
defensive loading
Will probably look into the |
@philippjfr this is ready to be reviewed, if you want to have a look into |
Made a few changes after some discussion:
|
If #810 is not expected to be in the next release, can you add these changes to this PR? |
@philippjfr do you still want to have a look at the |
Go ahead and merge, |
Thanks for your great work here! |
Fixes #764
Fixes #787
Should the accessors be patched by default whenI changed my mind, less side effects are better, at least for a start.hvplot.explorer
is called? I think so.Should the explorer allow to switch the plotting backend? I'm not sure.Let's keep it simple for now.@philippjfr in 87b07b4 I've removed the
__new__
methods. They were causing__init__
to be called twice, which wasn't really an issue as far as I could tell but was for sure undesired. I found no way to fix that by keeping them, so replaced them by a factory class methodfrom_data
that I use in theexplorer
function. This is a breaking change, which might be fine given that the explorer has been released recently and never documented. If this breaking change is unwanted, I could add a warning when an explorer isn't instantiated withfrom_data
, or keep digging to try to fix the issue with__new__
.