Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive: no DynamicMap when hvplot kind is not a string #858

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Interactive: no DynamicMap when hvplot kind is not a string #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion hvplot/interactive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,7 @@ def __call__(self, *args, _kind=None, **kwargs):
new = self._interactive._resolve_accessor()
transform = new._transform
transform = type(transform)(transform, 'hvplot', accessor=True)
dmap = 'kind' not in kwargs or not isinstance(kwargs['kind'], str)
dmap = 'kind' not in kwargs or isinstance(kwargs['kind'], str)
return new._clone(transform(*args, **kwargs), dmap=dmap)

def __getattr__(self, attr):
Expand Down
3 changes: 1 addition & 2 deletions hvplot/tests/testinteractive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ def test_interactive_xarray_dataset_hvplot_accessor(dataarray):
dai.hvplot.line(kind="area")


@pytest.mark.xfail(reason='Not sure?')
def test_interactive_pandas_dataframe_hvplot_accessor_dmap(df):
dfi = df.interactive()
dfi = dfi.hvplot.line(y='A')
Expand All @@ -219,7 +218,7 @@ def test_interactive_pandas_dataframe_hvplot_accessor_dmap_kind_widget(df):
dfi = df.interactive()
dfi = dfi.hvplot(kind=w, y='A')

assert dfi._dmap is True
assert dfi._dmap is False


def test_interactive_with_bound_function_calls():
Expand Down