Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit #967

Merged
merged 8 commits into from
Nov 18, 2022
Merged

Add pre-commit #967

merged 8 commits into from
Nov 18, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 16, 2022

Adding pre-commit. The pre-commit itself is inspired by Holoviews, though I tried adding ruff instead of flake8, this can of course be reversed if needed.

I can also add isort if needed.

hvplot/interactive.py Outdated Show resolved Hide resolved
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let's not use ruff in hvPlot. It's:

  • too new
  • more useful for large code bases
  • an incomplete re-implementation of flake8 (why not making flake8 faster instead?)

doit test_flakes should also be updated.

@maximlt maximlt merged commit 26c54e7 into master Nov 18, 2022
@maximlt maximlt deleted the add_precommit branch November 18, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants