New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming Target #392
Comments
Just brainstorming for alternatives with no attachment to any of them: |
The name |
+1 for I'm just going to throw out |
Could |
If |
I think
|
Another candidate could be something like |
Really appreciate everyones input, especially the alternative naming suggestions. I've tried a few of them by doing a search and replace in the docs and seeing if they make sense in that context. Doing that made it pretty obvious that Layout is the only one that really works. There may have been an argument to let the class name ( |
I suppose that is probably best...we already need to qualify all our uses of layout: 'holoviews layout', 'panel layout', 'bokeh layout' and now we would have 'lumen layout'. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
With the Lumen 0.5.0 release finally coming up we've got one last chance to fix naming mistakes in Lumen. One major sticking point has always been the
Target
component. This name came about as a natural pair to the dataSource
, where data would flow from source to target. However, even then it never really made sense and since there's been quite a lot of refactoring that more cleanly separates views, filters and transforms (which used to be grouped together on a target).This means that now a
Target
is defined as a component consisting of one or more view components that consume data from a pipeline and render the views into a layout. Therefore I suggest I finally pull the trigger and simply renameTarget
->Layout
. Alternatively I could also considerLayoutGroup
as the name of the Python class but keep the YAML key aslayouts
.I'd like to collect everyone's opinion so please chime in @Hoxbro, @maximlt, @jbednar, @droumis, @jlstevens and @eli-pinkus.
The text was updated successfully, but these errors were encountered: