Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Target to Layout #393

Merged
merged 2 commits into from Nov 30, 2022
Merged

Rename Target to Layout #393

merged 2 commits into from Nov 30, 2022

Conversation

philippjfr
Copy link
Member

Closes #392

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #393 (9a4f175) into master (dceec94) will increase coverage by 0.02%.
The diff coverage is 76.56%.

❗ Current head 9a4f175 differs from pull request most recent head 282127e. Consider uploading reports for the commit 282127e to get more accurate results

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   68.15%   68.17%   +0.02%     
==========================================
  Files          73       73              
  Lines        8111     8117       +6     
==========================================
+ Hits         5528     5534       +6     
  Misses       2583     2583              
Impacted Files Coverage Δ
lumen/filters/base.py 71.42% <ø> (ø)
lumen/ui/dashboard.py 35.82% <0.00%> (ø)
lumen/ui/main.py 38.46% <0.00%> (ø)
lumen/ui/views.py 40.50% <0.00%> (ø)
lumen/ui/builder.py 23.80% <7.14%> (ø)
lumen/ui/layouts.py 35.13% <41.66%> (ø)
lumen/dashboard.py 78.44% <80.95%> (+0.08%) ⬆️
lumen/state.py 66.53% <84.61%> (ø)
lumen/__init__.py 100.00% <100.00%> (ø)
lumen/layout.py 80.99% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 6f00c47 into master Nov 30, 2022
@philippjfr philippjfr deleted the target_rename branch November 30, 2022 12:26
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming Target
2 participants