Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable launcher gallery #270

Merged
merged 3 commits into from
May 4, 2022
Merged

Add configurable launcher gallery #270

merged 3 commits into from
May 4, 2022

Conversation

philippjfr
Copy link
Member

Previously it was only possible to configure a single launcher via the CLI --launcher argument. This did not allow a lot of configurability and often you want to offer users multiple options for launching/deploying/exporting. This PR adds a Launcher gallery which can be configured just like any other components by adding yaml specifications to the ./components/launchers/ directory.

Screen Shot 2022-05-04 at 15 33 40

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #270 (446dcbb) into master (93d1081) will decrease coverage by 0.33%.
The diff coverage is 41.81%.

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   65.43%   65.10%   -0.34%     
==========================================
  Files          57       57              
  Lines        5511     5559      +48     
==========================================
+ Hits         3606     3619      +13     
- Misses       1905     1940      +35     
Impacted Files Coverage Δ
lumen/ui/base.py 34.72% <ø> (-4.17%) ⬇️
lumen/ui/main.py 31.81% <0.00%> (-1.52%) ⬇️
lumen/ui/sources.py 50.45% <ø> (ø)
lumen/ui/state.py 75.60% <ø> (-0.59%) ⬇️
lumen/ui/builder.py 27.43% <25.00%> (-1.14%) ⬇️
lumen/ui/gallery.py 44.28% <33.33%> (-0.50%) ⬇️
lumen/ui/launcher.py 50.00% <44.68%> (-15.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d1081...446dcbb. Read the comment docs.

@philippjfr philippjfr merged commit 8973026 into master May 4, 2022
@maximlt maximlt deleted the launcher_gallery branch May 4, 2022 21:22
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants