-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initializing the how to section #325
Conversation
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
c90703f
to
84685e4
Compare
docs/how_to/chain_python.md
Outdated
|
||
pipeline.data | ||
``` | ||
![data preview](../_static/pipeline_data.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the screenshots here? I'll add the pyodide rendering extension in a separate PR and then the output will be generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philippjfr so you want all the screenshots removed across the how to guides, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for this how to guide for now I think since it's very simple, for the other one I'm not sure yet so let's leave it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Now you can apply a `transform` to the data, such as computing the mean or selecting certain columns. See the [Transform Reference](../architecture/transform) for more. | ||
|
||
```{code-block} python | ||
:emphasize-lines: 14-15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have to see if I can get emphasis working in the pyodide extension so we can have live output here too.
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 71 71
Lines 7210 7210
=======================================
Hits 4813 4813
Misses 2397 2397 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The emphasis does not look great on the dev site.. also, the how-to names overflow on the left nav.. :( |
That's okay, we can make some tweaks to give a little bit more space and make the highlight stand out more in a separate PR. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I personally don't think we should subsection the How-to until there is more than a handful of specific pages of content.. otherwise, it just seems like structural bloat.
Reminder about How to section guidelines: