Improve the logic behind importing a module #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
changed the title
maximlt
reviewed
Sep 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
- Coverage 67.25% 67.24% -0.02%
==========================================
Files 71 71
Lines 7370 7373 +3
==========================================
+ Hits 4957 4958 +1
- Misses 2413 2415 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a module was not installed, it would raise a very ambiguous error message:
This is because the
__import__did not look if the import error was caused by the actually import or one of a dependency inside the file imported.When failing, the error message could be improved, but I want some feedback on if this is the way forward.