Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for exporting View and Target to_spec #365

Merged
merged 6 commits into from
Oct 22, 2022

Conversation

philippjfr
Copy link
Member

This rounds out our ability to declare Lumen components programmatically. We can now build View and Target components programmatically and then export them to a specification.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #365 (e9cdd0b) into master (18878b1) will increase coverage by 0.69%.
The diff coverage is 80.23%.

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   66.14%   66.84%   +0.69%     
==========================================
  Files          72       72              
  Lines        7710     7863     +153     
==========================================
+ Hits         5100     5256     +156     
+ Misses       2610     2607       -3     
Impacted Files Coverage Δ
lumen/base.py 79.72% <0.00%> (+1.42%) ⬆️
lumen/ui/sources.py 48.46% <0.00%> (-0.57%) ⬇️
lumen/state.py 62.14% <6.66%> (-3.37%) ⬇️
lumen/views/base.py 62.62% <59.09%> (+1.03%) ⬆️
lumen/pipeline.py 57.95% <80.00%> (+4.90%) ⬆️
lumen/target.py 78.22% <83.33%> (+1.21%) ⬆️
lumen/tests/test_target.py 100.00% <100.00%> (ø)
lumen/tests/views/test_base.py 100.00% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 2cd50df into master Oct 22, 2022
@philippjfr philippjfr deleted the target_to_spec branch October 22, 2022 12:57
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants