Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and test SQLTransforms #384

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Clean up and test SQLTransforms #384

merged 3 commits into from
Nov 14, 2022

Conversation

philippjfr
Copy link
Member

Adds some tests for SQLTransform components and cleans up the generated SQL queries.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #384 (110d03b) into master (bb827b4) will increase coverage by 0.21%.
The diff coverage is 97.91%.

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   67.25%   67.47%   +0.21%     
==========================================
  Files          72       73       +1     
  Lines        7976     8033      +57     
==========================================
+ Hits         5364     5420      +56     
- Misses       2612     2613       +1     
Impacted Files Coverage Δ
lumen/pipeline.py 59.94% <50.00%> (+0.17%) ⬆️
lumen/tests/transforms/test_sql.py 100.00% <100.00%> (ø)
lumen/transforms/sql.py 94.28% <100.00%> (+1.65%) ⬆️
lumen/views/base.py 62.66% <0.00%> (+0.07%) ⬆️
lumen/base.py 83.54% <0.00%> (+0.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 0ce3420 into master Nov 14, 2022
@philippjfr philippjfr deleted the sql_fixes branch November 14, 2022 11:36
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants