Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title option to view #430

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Add title option to view #430

merged 3 commits into from
Jan 17, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 17, 2023

import panel as pn
from lumen.layout import Layout
from lumen.pipeline import Pipeline
from lumen.sources import FileSource
from lumen.views import Table

pn.extension("tabulator")

data_url = "https://datasets.holoviz.org/penguins/v1/penguins.csv"

pipeline = Pipeline(source=FileSource(tables={"penguins": data_url}), table="penguins")
pipeline.add_transform("iloc", end=5)

table1 = Table(pipeline=pipeline, title="Title 1", download="csv")
table2 = Table(pipeline=pipeline, title="Title 2")
table3 = Table(pipeline=pipeline)
table4 = Table(pipeline=pipeline, download="csv")

Layout(views=[table1, table2, table3, table4], title="Tables")

image

  • Need to write some unit tests
  • Document it somewhere in the docs

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Merging #430 (abb9595) into main (f0ed415) will decrease coverage by 0.03%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   69.10%   69.08%   -0.03%     
==========================================
  Files          76       76              
  Lines        8724     8733       +9     
==========================================
+ Hits         6029     6033       +4     
- Misses       2695     2700       +5     
Impacted Files Coverage Δ
lumen/views/base.py 63.65% <54.54%> (-0.32%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lumen/views/base.py Outdated Show resolved Hide resolved
@philippjfr
Copy link
Member

If you find somewhere in the docs submit a new PR. For now I'd like to merge and cut a dev release.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@philippjfr philippjfr merged commit ad18a9b into main Jan 17, 2023
@philippjfr philippjfr deleted the add_title_to_views branch January 17, 2023 16:52
@droumis droumis mentioned this pull request Jan 17, 2023
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants