Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow referencing Variable in Pipeline table definition #478

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

philippjfr
Copy link
Member

In order to provide nice error messages the Pipeline tried to eagerly resolve the table on the underlying source but if the table was actually a reference to a Variable this would error out. To address this we resolve the reference if needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Merging #478 (9f02fc1) into main (f2d19c7) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   69.20%   69.22%   +0.01%     
==========================================
  Files          78       78              
  Lines        9061     9062       +1     
==========================================
+ Hits         6271     6273       +2     
+ Misses       2790     2789       -1     
Files Changed Coverage Δ
lumen/pipeline.py 64.55% <33.33%> (-0.17%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 57307b2 into main Aug 22, 2023
6 of 10 checks passed
@philippjfr philippjfr deleted the pipeline_table_variable branch August 22, 2023 15:37
Copy link

github-actions bot commented Dec 5, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants