Fuzzy table matching part 2 #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuang11
commented
May 13, 2024
| @@ -213,6 +214,8 @@ async def _invalidate_memory(self, messages): | |||
| invalid_key = validity.invalid_key | |||
| if invalid_key == "table": | |||
| memory.pop("current_table", None) | |||
| memory.pop("current_data", None) | |||
There was a problem hiding this comment.
Pop out stale data
ahuang11
commented
May 13, 2024
| @@ -182,8 +182,9 @@ def use_suggestion(event): | |||
| async def _invalidate_memory(self, messages): | |||
| table = memory.get("current_table") | |||
| sql = memory.get("current_sql") | |||
| if not sql: | |||
| if not table and not sql: | |||
There was a problem hiding this comment.
Be sure to invalidate table too.
ahuang11
commented
May 13, 2024
Comment on lines
-335
to
-345
| source = memory.get("current_source") | ||
| tables = source.get_tables() if source else [] | ||
| if len(tables) > FUZZY_TABLE_LENGTH: | ||
| closest_tables = await self._get_closest_tables(messages, tables, n=5) | ||
| if len(closest_tables) == 0: | ||
| # if no tables are found, ask the user to select ones and load it | ||
| tables = await self._select_table(tables) | ||
| return self.requires + ['current_table'] | ||
| elif len(closest_tables) == 1: | ||
| return self.requires + ['current_table'] | ||
|
|
There was a problem hiding this comment.
Not needed with better logic in invalidating and checks.
ahuang11
commented
May 13, 2024
| return tuple(closest_tables) | ||
| if len(closest_tables) == 0: | ||
| # if no tables are found, ask the user to select ones and load it | ||
| tables = await self._select_table(tables) |
There was a problem hiding this comment.
Only select if unavailable to auto select.
philippjfr
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.