Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use model_kwargs as param #555

Merged
merged 2 commits into from
May 15, 2024
Merged

use model_kwargs as param #555

merged 2 commits into from
May 15, 2024

Conversation

ahuang11
Copy link
Contributor

Allow setting custom model kwargs

@ahuang11 ahuang11 requested a review from philippjfr May 14, 2024 20:01
philippjfr
philippjfr approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it could have been a completely independent change. Can we try to keep PRs separate in future so it's easier to review?

@philippjfr philippjfr merged commit 1440c00 into keep_sql May 15, 2024
1 of 11 checks passed
@philippjfr philippjfr deleted the model_kwargs_as_param branch May 15, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahuang11 @philippjfr