Fix cleanup of children on ReactiveHTML (#2993)

holoviz · Dec 8, 2021 · 2dba064 · 2dba064
1 parent f5a099d
commit 2dba064
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/panel/reactive.py b/panel/reactive.py
@@ -1299,7 +1299,7 @@ def __init__(self, **params):
     def _cleanup(self, root):
         for child, panes in self._panes.items():
             for pane in panes:
-                child._cleanup(root)
+                pane._cleanup(root)
         super()._cleanup(root)
 
     @property

diff --git a/panel/tests/test_reactive.py b/panel/tests/test_reactive.py
@@ -300,6 +300,10 @@ class TestChildren(ReactiveHTML):
     assert root.children == {'div': [widget_new._models[root.ref['id']][0]]}
     assert test._panes == {'children': [widget_new]}
 
+    test._cleanup(root)
+    assert len(test._models) == 0
+    assert len(widget_new._models) == 0
+
 
 def test_reactive_html_templated_children():