Skip to content

Commit

Permalink
Ensure filters update data on local pagination
Browse files Browse the repository at this point in the history
  • Loading branch information
philippjfr committed Sep 16, 2022
1 parent 8808cdb commit 7847ff8
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions panel/widgets/tables.py
Expand Up @@ -363,7 +363,9 @@ def _filter_dataframe(self, df: DataFrameType) -> DataFrameType:
else:
val = filt
column = df[col_name]
if np.isscalar(val):
if val is None:
continue
elif np.isscalar(val):
mask = column == val
elif isinstance(val, (list, set)):
if not val:
Expand Down Expand Up @@ -1438,7 +1440,9 @@ def _update_cds(self, *events):
page_events = ('page', 'page_size', 'sorters', 'filters')
if self._updating:
return
elif (events and all(e.name in page_events for e in events) and (self.pagination in (None, 'local'))):
elif events and all(e.name in page_events[:-1] for e in events) and self.pagination == 'local':
return
elif events and all(e.name in page_events for e in events) and not self.pagination:
self._processed, _ = self._get_data()
return
recompute = not all(
Expand Down

0 comments on commit 7847ff8

Please sign in to comment.