VTK Synchronized #1248

xavArtley · 2020-04-09T12:42:45Z

supersede: #1070

Remaining tasks:

clean code (remove old serializer, refactor render function on js side, ...)
Split the old VTK pane in:
- VTKJS (to load vtkjs files)
- VTKSynchronized to handle vtkrender window
to handle vtkScalarBarActor (colorbar [VTK] Add colorbar on vtk renderer #1270)
Documentation:
- split old VTK notebook
- update gallery interactive demo

Future tasks (in an other PR)

discussion on the API we want to expose
extend the serializer
- to handle volumes (will need vtk-js modifications)
new Notebook to document capabilites of VTKSynchronized pane

@philippjfr I think the PR is ready for review, everithing should almost work as before.
There are some small API breaks (for colorbars and mostly on javascript side)

I'll make more doc improvement in an other PR

panel/models/vtk/vtksynchronized.ts

codecov · 2020-04-09T13:38:09Z

Codecov Report

❗ No coverage uploaded for pull request head (xav/python-link-interactivity@8487cf5). Click here to learn what that means.
The diff coverage is n/a.

xavArtley · 2020-04-09T14:04:54Z

For the vtkLookupTable, I think you want to create vtk.Rendering.Core.vtkColorTransferFunction not the basic one that use the HueRange.

Originally posted by @jourdain in #1070 (comment)

Indeed it works. I thought vtkColortransferfunction was for volumes

philippjfr · 2020-04-09T14:08:51Z

panel/_package-lock.json

@@ -0,0 +1,359 @@
+{


Why check this in if regular old package-lock.json is now checked in?

actually I haven't succeed to use jszip and vtk in typescript for the moment
jszip I have an error with readable-stream
and vtkjs on importation.
bokeh/bokeh#9198 (comment)

I'm actually currently at a strong -1 on bundling vtk.js with panel.js. Once bokeh allows multiple bundles in an extension we can add a panel-vtk.js bundle but for now it's too large to be included by default.

this is the error I get when trying to add jszip and @types/jszip to node modules:

Compiling TypeScript (30 files) Linking modules Error: can't resolve 'stream' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\readable-stream\readable.js' at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20) at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29) at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43) at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37) at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36) at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32) at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46) at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5) at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23) at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16 Error: can't resolve 'events' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\readable-stream\lib\_stream_readable.js' at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20) at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29) at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43) at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37) at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36) at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32) at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46) at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5) at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23) at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16 Error: can't resolve 'util' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\readable-stream\lib\_stream_readable.js' at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20) at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29) at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43) at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37) at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36) at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32) at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46) at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5) at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23) at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16 Error: can't resolve 'stream' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\readable-stream\lib\internal\streams\stream.js' at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20) at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29) at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43) at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37) at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36) at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32) at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46) at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5) at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23) at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16 Error: can't resolve 'buffer' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\safe-buffer\index.js' at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20) at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29) at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43) at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37) at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36) at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32) at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46) at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5) at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23) at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16 Error: can't resolve 'util' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\inherits\inherits.js' at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20) at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29) at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43) at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37) at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36) at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32) at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46) at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5) at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23) at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16 Error: can't resolve 'util' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\readable-stream\lib\internal\streams\BufferList.js' at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20) at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29) at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43) at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37) at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36) at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32) at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46) at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5) at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23) at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16 Error: can't resolve 'util' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\util-deprecate\node.js' at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20) at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29) at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43) at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37) at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36) at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32) at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46) at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5) at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23) at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16

may be @mattpap has an idea to solve it

jourdain · 2020-04-09T14:30:49Z

Python serializer:
I've updated our version here. I still need to validate it inside PVW to make sure I didn't break anything.

In the mean time it should be pretty close to the one you had (except your last lut change). Could you test it? If we can I would like to have (if possible) the exact same file... ;-)

Thanks @xavArtley !

xavArtley · 2020-04-09T15:48:02Z

Python serializer:
I've updated our version here. I still need to validate it inside PVW to make sure I didn't break anything.

In the mean time it should be pretty close to the one you had (except your last lut change). Could you test it? If we can I would like to have (if possible) the exact same file... ;-)

Thanks @xavArtley !

@jourdain I think you should not keep this :
https://gitlab.kitware.com/vtk/vtk/-/merge_requests/6707/diffs#0ad8a8250f77efb2ca8213329f7c901a030a1477_314_494
in vtkjs there is no proper set function for the rotation matrix and it's just a (temporary?) workaround for the orientation not taking into account, moreover I think it works only if the actor position is in (0,0,0)
it's just suppositions, I'm really not an expert in 3d transformations

jourdain · 2020-04-09T18:36:54Z

I had to make some changes, but now it works as-is in my pvw legacy codes. @xavArtley see if that works for you?
https://gitlab.kitware.com/vtk/vtk/-/merge_requests/6707

xavArtley · 2020-04-10T07:36:07Z

Another, potentially lighter-weight option could be to subclass vtkArchiver in Python and reimplement vtkPartitionedArchiver and its compression routines entirely in Python. I have experience subclassing C++ classes in Python to be useable in C++ using pybind11, so it is definitely doable. This would provide the additional benefit of confining the temperamental logic of serializing a VTK scene into vtk-js to one place.

Originally posted by @tjcorona in #1070 (comment)

I'll be interesting to learn how to do this.
I have never tried to subclass a vtkclass
Do you have some reference code that I can inspired or any guidance to achieve it?

xavArtley · 2020-04-10T09:23:17Z

@jourdain I had to modify the hashDataArray to use md5 hexdigest instead of digest otherwise I have some problems to decode zipped array on javascript side due to / special char

jourdain · 2020-04-10T09:37:33Z

Thanks I've noticed and keep up with it. But I had to remove the numpy dependency for the LUT. But that could be achieved using a file on the side...

xavArtley · 2020-04-10T09:40:46Z

I think I can remove numpy dependency if you want.
Was just more convenient to extract values of a vtkArray

jourdain · 2020-04-10T09:43:59Z

If you want, to use the file from vtk 9.0 as-is then yes...

jourdain · 2020-04-10T09:48:11Z

I'm ready to merge... So if you want to take the latest version of that file from my MR and add the LUT handling without numpy while making sure that everything works as expected for you that would be great.

With your latest edit/add-on, I'll trigger another test dashboard along with a pvw deployment to be sure...

And if everything is good to go, I'll merge it into VTK.

xavArtley · 2020-04-10T16:06:44Z

I'm ready to merge... So if you want to take the latest version of that file from my MR and add the LUT handling without numpy while making sure that everything works as expected for you that would be great.

With your latest edit/add-on, I'll trigger another test dashboard along with a pvw deployment to be sure...

And if everything is good to go, I'll merge it into VTK.

I have tested your last file it's seems working except for the mapper:
I have a vtkOpenGLPolyDataMapper but there is no alias for it in vtk.js:
https://github.com/Kitware/vtk-js/blob/c4459d8682107f241dec3c2e3d77f00a4d266d4e/Sources/Rendering/Misc/SynchronizableRenderWindow/vtkObjectManager.js#L413

I think these lint error will not pass our tests

jourdain · 2020-04-10T16:27:42Z

I can add the mapping in vtkJS, it is easy enough. Do you want to do a PR?
I've already merged the py file in vtk/master+release but I can fix (remove) the unused import...

jourdain · 2020-04-11T09:50:54Z

vtk 13.13.2 has the new mapping.

xavArtley · 2020-04-11T14:15:09Z

@jourdain is there any sticking point to extent the synchronize renderer to handle vtkVolumes?

xavArtley · 2020-04-12T07:47:30Z

Example of vtkActor animation and possibility to link and unlink camera beetween panels:
In the example after the first rotation of the both views shared camera and after the second rotation camera are unlinked

jourdain · 2020-04-12T10:06:52Z

No specific reason for not handling volume, we just didn't had the need so far.
In term of work we would just need new serializers on the Python side and the proper mapping on the client side. But as you may know by now, it is not too difficult or too long to do.

xavArtley · 2020-04-12T10:12:25Z

Thx good to know, I didn't want to start this and go in a dead end

xavArtley · 2020-04-15T08:04:29Z

I think most of all fonctionalities of the old panel are functionals

xavArtley · 2020-04-16T09:32:34Z

I run into a problem that I cannot solve.
This involves displaying the same panel several times
As long as we don't try to display elements like the orientation widget or the axes, there is no problem. But all the elements that do not belong to the python-side rendering window are complicated to manage because the scene is just updated and no longer rebuilt from scratch.

xavArtley · 2020-05-13T13:34:18Z

I can't reproduce the traverse error

jbednar · 2020-05-13T14:28:56Z

My suggestions would be to make VTK a baseclass with a new method, which creates the appropriate subclass, which can be either VTKJS or VTKRenderWindow, does that sound reasonable?

I very much hope this can be done, because otherwise users have to learn which object to select, a much more difficult task than learning which option on an object to select. Figuring out options with help(obj) is easy once you have an obj; figuring out which object to use out of all the objects in Panel is difficult, and once they start with one of them many users won't realize that others are available.

xavArtley · 2020-05-13T14:31:24Z

I have implemented it in last commit. And actiually it does not work :)

xavArtley · 2020-05-13T14:46:52Z

@philippjfr I reproduced on linux

jbednar

Great stuff! I've done a good bit of editing of the notebook text, and I hope none of that breaks the JSON file format. It shouldn't, but it's worth loading the notebook into Jupyter after applying the changes just to make sure.

examples/reference/panes/VTK.ipynb

jbednar · 2020-05-13T14:36:53Z

examples/reference/panes/VTK.ipynb

+    "* **``link_camera(other: VTK)``** : Both panel will share the same camera, any change in one panel camera will be applied in the link panel\n",
+    "\n",
+    "**Warning** for applying any modification generated by these methods, the `sychronize()` method must be called\n",
+    "___"


Not sure what these underscores are for?

It's for the horizontal separator

examples/reference/panes/VTK.ipynb

panel/models/vtk.py

examples/reference/panes/VTKJS.ipynb

Co-authored-by: James A. Bednar <jbednar@users.noreply.github.com>

xavArtley · 2020-05-13T16:03:46Z

Great stuff! I've done a good bit of editing of the notebook text, and I hope none of that breaks the JSON file format. It shouldn't, but it's worth loading the notebook into Jupyter after applying the changes just to make sure.

I have tested nothing breaks

xavArtley · 2020-05-13T16:05:10Z

@philippjfr it should work now

philippjfr · 2020-05-13T17:23:40Z

@philippjfr it should work now

Can confirm, works now.

philippjfr · 2020-05-13T18:03:50Z

Okay, I have one last question, what happened to VTK.construct_colorbars()? I take it this now happens client-side but if we want to remove it we should go through an actual deprecation cycle, i.e. start warning in this release and remove it in the next release. Is that problematic?

For background I have seen multiple user notebooks that used this functionality and breaking it in a minor release isn't ideal.

philippjfr · 2020-05-13T18:06:06Z

Apart from that this is all looks great, thanks for all your efforts here, they are hugely appreciated!

panel/pane/vtk/vtk.py

xavArtley · 2020-05-16T07:48:45Z

@philippjfr , @jbednar
I have a concern that emerged this week,
it concerns the moment when the serialization of the object (vtkRenderWindow) takes place.
Currently, it only happens when _get_model or _update is called
Formerly, I had the serialize_on_instantiation parameter which allowed serializing at the construction of the object.
This made it possible to avoid a problem in pyvista because the VTK pane was instantiated then the VTKRenderWindow was cleaned before displaying.
If serialize_on_instantiation was False, an empty pane was displayed. The solution was therefore to serialize at instantiation.
In this case we are no longer really on a synchronized pane, so I was wondering if I should not do two classes:
VTKRenderWindowSynchronized and VTKRenderWindow, where the switch was made depending on whether we are serializing on instantiation or not.

philippjfr · 2020-05-19T21:59:10Z

VTKRenderWindowSynchronized and VTKRenderWindow, where the switch was made depending on whether we are serializing on instantiation or not.

Is this still needed or did your latest changes address this?

xavArtley · 2020-05-20T05:03:19Z

My last changed adress it

xavArtley · 2020-06-12T04:59:48Z

Hello @jourdain,

I found my mistake I didn't pass range to the serialize lookuptable but I used valueRange

~~I need your help on an issue.~~
~~When trying to solve a panel issue I encounter another issue with the convertion of scalars to colors.~~

~~This issue occur when I set the mapper to use the lookup table range mapper.UseLookupTableScalarRangeOn()~~
~~This is the result I obtained:~~

~~However if I set UseLookupTableScalarRangeOff, I get similar results as with VTK C++~~

~~You can download the zip file of the scene here:~~
~~https://drive.google.com/drive/folders/1kgxkS3VyvcZFcTuBL2ty_cTtdUr37wmg?usp=sharing~~
~~you can use it in https://kitware.github.io/vtk-js/examples/SynchronizableRenderWindow.html~~

~~The scene piece is a composition of 32 actors~~

~~I'll try to make a smaller reproducing example later~~

jourdain · 2020-06-15T10:24:34Z

Glad you figure it out... Sorry I could not provide much help. I'm off till the end of the week.

xavArtley added status: WIP type: enhancement Minor feature or improvement to an existing feature labels Apr 9, 2020

jourdain reviewed Apr 9, 2020

View reviewed changes

panel/models/vtk/vtksynchronized.ts Outdated Show resolved Hide resolved

xavArtley force-pushed the xav/python-link-interactivity branch from c7b850b to 60497f2 Compare April 9, 2020 13:26

philippjfr reviewed Apr 9, 2020

View reviewed changes

xavArtley force-pushed the xav/python-link-interactivity branch from 6135cb4 to fa66555 Compare April 9, 2020 15:10

xavArtley force-pushed the xav/python-link-interactivity branch from 7689045 to 0f45264 Compare April 10, 2020 09:17

xavArtley force-pushed the xav/python-link-interactivity branch from 80ef025 to 503f211 Compare April 10, 2020 16:22

xavArtley force-pushed the xav/python-link-interactivity branch from a302918 to 04efc63 Compare April 11, 2020 17:53

xavArtley force-pushed the xav/python-link-interactivity branch from 3673add to dc24b61 Compare April 12, 2020 14:14

merge VTK and VTKJS

f61d579

xavArtley force-pushed the xav/python-link-interactivity branch from 6ebd4f1 to 6fd801b Compare May 13, 2020 15:19

linux vtkSmartVolumeMapper

841cb59

xavArtley force-pushed the xav/python-link-interactivity branch from 6fd801b to 841cb59 Compare May 13, 2020 15:22

jbednar reviewed May 13, 2020

View reviewed changes

xavArtley and others added 2 commits May 13, 2020 17:53

Apply suggestions from code review

e15284d

Co-authored-by: James A. Bednar <jbednar@users.noreply.github.com>

Apply suggestions from code review

e35317c

Co-authored-by: James A. Bednar <jbednar@users.noreply.github.com>

reimplement construct_colorbar

202c777

xavArtley force-pushed the xav/python-link-interactivity branch from 546db69 to 202c777 Compare May 13, 2020 20:00

philippjfr reviewed May 13, 2020

View reviewed changes

panel/pane/vtk/vtk.py Outdated Show resolved Hide resolved

reimplement serialize_on_instantiation

f10989c

xavArtley force-pushed the xav/python-link-interactivity branch from 63f11da to f10989c Compare May 18, 2020 12:31

add axes only if renderer exists

8487cf5

banesullivan mentioned this pull request May 18, 2020

Refactor/re-brand ipyparaview for use with VTK or ParaView backend Kitware/resonanthpc#16

Open

philippjfr merged commit d4375db into master Jun 11, 2020

philippjfr deleted the xav/python-link-interactivity branch June 11, 2020 19:06

VTK Synchronized #1248

VTK Synchronized #1248

Conversation

xavArtley commented Apr 9, 2020 • edited by philippjfr

codecov bot commented Apr 9, 2020 • edited

Codecov Report

xavArtley commented Apr 9, 2020

philippjfr Apr 9, 2020

Choose a reason for hiding this comment

xavArtley Apr 9, 2020 • edited

Choose a reason for hiding this comment

philippjfr Apr 9, 2020 • edited

Choose a reason for hiding this comment

xavArtley Apr 9, 2020 • edited

Choose a reason for hiding this comment

jourdain commented Apr 9, 2020

xavArtley commented Apr 9, 2020 • edited

jourdain commented Apr 9, 2020

xavArtley commented Apr 10, 2020 • edited

xavArtley commented Apr 10, 2020

jourdain commented Apr 10, 2020

xavArtley commented Apr 10, 2020

jourdain commented Apr 10, 2020

jourdain commented Apr 10, 2020

xavArtley commented Apr 10, 2020 • edited

jourdain commented Apr 10, 2020

jourdain commented Apr 11, 2020 • edited

xavArtley commented Apr 11, 2020

xavArtley commented Apr 12, 2020

jourdain commented Apr 12, 2020 • edited

xavArtley commented Apr 12, 2020 • edited

xavArtley commented Apr 15, 2020 • edited

xavArtley commented Apr 16, 2020 • edited

xavArtley commented May 13, 2020

jbednar commented May 13, 2020

xavArtley commented May 13, 2020 via email • edited

xavArtley commented May 13, 2020

jbednar left a comment

Choose a reason for hiding this comment

jbednar May 13, 2020

Choose a reason for hiding this comment

xavArtley May 13, 2020

Choose a reason for hiding this comment

xavArtley commented May 13, 2020

xavArtley commented May 13, 2020

philippjfr commented May 13, 2020

philippjfr commented May 13, 2020 • edited

philippjfr commented May 13, 2020

xavArtley commented May 16, 2020 • edited

philippjfr commented May 19, 2020

xavArtley commented May 20, 2020

xavArtley commented Jun 12, 2020 • edited

jourdain commented Jun 15, 2020

xavArtley commented Apr 9, 2020 •

edited by philippjfr

codecov bot commented Apr 9, 2020 •

edited

xavArtley Apr 9, 2020 •

edited

philippjfr Apr 9, 2020 •

edited

xavArtley Apr 9, 2020 •

edited

xavArtley commented Apr 9, 2020 •

edited

xavArtley commented Apr 10, 2020 •

edited

xavArtley commented Apr 10, 2020 •

edited

jourdain commented Apr 11, 2020 •

edited

jourdain commented Apr 12, 2020 •

edited

xavArtley commented Apr 12, 2020 •

edited

xavArtley commented Apr 15, 2020 •

edited

xavArtley commented Apr 16, 2020 •

edited

xavArtley commented May 13, 2020 via email •

edited

philippjfr commented May 13, 2020 •

edited

xavArtley commented May 16, 2020 •

edited

xavArtley commented Jun 12, 2020 •

edited