-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTK Synchronized #1248
VTK Synchronized #1248
Conversation
c7b850b
to
60497f2
Compare
Codecov Report
|
Indeed it works. I thought vtkColortransferfunction was for volumes |
@@ -0,0 +1,359 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why check this in if regular old package-lock.json is now checked in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I haven't succeed to use jszip and vtk in typescript for the moment
jszip I have an error with readable-stream
and vtkjs on importation.
bokeh/bokeh#9198 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually currently at a strong -1 on bundling vtk.js with panel.js. Once bokeh allows multiple bundles in an extension we can add a panel-vtk.js bundle but for now it's too large to be included by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the error I get when trying to add jszip and @types/jszip to node modules:
Compiling TypeScript (30 files)
Linking modules
Error: can't resolve 'stream' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\readable-stream\readable.js'
at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20)
at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29)
at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43)
at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37)
at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36)
at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32)
at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46)
at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5)
at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23)
at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16
Error: can't resolve 'events' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\readable-stream\lib\_stream_readable.js'
at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20)
at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29)
at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43)
at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37)
at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36)
at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32)
at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46)
at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5)
at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23)
at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16
Error: can't resolve 'util' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\readable-stream\lib\_stream_readable.js'
at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20)
at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29)
at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43)
at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37)
at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36)
at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32)
at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46)
at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5)
at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23)
at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16
Error: can't resolve 'stream' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\readable-stream\lib\internal\streams\stream.js'
at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20)
at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29)
at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43)
at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37)
at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36)
at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32)
at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46)
at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5)
at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23)
at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16
Error: can't resolve 'buffer' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\safe-buffer\index.js'
at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20)
at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29)
at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43)
at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37)
at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36)
at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32)
at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46)
at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5)
at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23)
at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16
Error: can't resolve 'util' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\inherits\inherits.js'
at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20)
at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29)
at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43)
at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37)
at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36)
at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32)
at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46)
at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5)
at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23)
at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16
Error: can't resolve 'util' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\readable-stream\lib\internal\streams\BufferList.js'
at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20)
at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29)
at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43)
at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37)
at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36)
at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32)
at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46)
at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5)
at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23)
at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16
Error: can't resolve 'util' from 'C:\Users\XA235208\Workspace\PythonWorkspace\modules\panel\panel\node_modules\util-deprecate\node.js'
at Linker.resolve_absolute (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149877:20)
at Linker.resolve_file (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149883:29)
at Linker.new_module (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149969:43)
at Linker.resolve (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:150012:37)
at Linker.link (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:149660:36)
at Object.build (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:148534:32)
at main (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:205:46)
at Object._ (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:237:5)
at require (C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:88:23)
at C:\Users\XA235208\Workspace\PythonEnvs\py38\lib\site-packages\bokeh\server\static\js\compiler.js:96:16
may be @mattpap has an idea to solve it
Python serializer: In the mean time it should be pretty close to the one you had (except your last lut change). Could you test it? If we can I would like to have (if possible) the exact same file... ;-) Thanks @xavArtley ! |
6135cb4
to
fa66555
Compare
@jourdain I think you should not keep this : |
I had to make some changes, but now it works as-is in my pvw legacy codes. @xavArtley see if that works for you? |
Originally posted by @tjcorona in #1070 (comment) I'll be interesting to learn how to do this. |
7689045
to
0f45264
Compare
@jourdain I had to modify the hashDataArray to use |
Thanks I've noticed and keep up with it. But I had to remove the numpy dependency for the LUT. But that could be achieved using a file on the side... |
I think I can remove numpy dependency if you want. |
If you want, to use the file from vtk 9.0 as-is then yes... |
I'm ready to merge... So if you want to take the latest version of that file from my MR and add the LUT handling without numpy while making sure that everything works as expected for you that would be great. With your latest edit/add-on, I'll trigger another test dashboard along with a pvw deployment to be sure... And if everything is good to go, I'll merge it into VTK. |
I have tested your last file it's seems working except for the mapper: I think these lint error will not pass our tests |
80ef025
to
503f211
Compare
I can add the mapping in vtkJS, it is easy enough. Do you want to do a PR? |
vtk 13.13.2 has the new mapping. |
@jourdain is there any sticking point to extent the synchronize renderer to handle vtkVolumes? |
a302918
to
04efc63
Compare
No specific reason for not handling volume, we just didn't had the need so far. |
Thx good to know, I didn't want to start this and go in a dead end |
3673add
to
dc24b61
Compare
I run into a problem that I cannot solve. |
I can't reproduce the traverse error |
I very much hope this can be done, because otherwise users have to learn which object to select, a much more difficult task than learning which option on an object to select. Figuring out options with |
I have implemented it in last commit.
And actiually it does not work :)
|
@philippjfr I reproduced on linux |
6ebd4f1
to
6fd801b
Compare
6fd801b
to
841cb59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I've done a good bit of editing of the notebook text, and I hope none of that breaks the JSON file format. It shouldn't, but it's worth loading the notebook into Jupyter after applying the changes just to make sure.
"* **``link_camera(other: VTK)``** : Both panel will share the same camera, any change in one panel camera will be applied in the link panel\n", | ||
"\n", | ||
"**Warning** for applying any modification generated by these methods, the `sychronize()` method must be called\n", | ||
"___" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what these underscores are for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: James A. Bednar <jbednar@users.noreply.github.com>
Co-authored-by: James A. Bednar <jbednar@users.noreply.github.com>
I have tested nothing breaks |
@philippjfr it should work now |
Can confirm, works now. |
Okay, I have one last question, what happened to For background I have seen multiple user notebooks that used this functionality and breaking it in a minor release isn't ideal. |
Apart from that this is all looks great, thanks for all your efforts here, they are hugely appreciated! |
546db69
to
202c777
Compare
@philippjfr , @jbednar |
63f11da
to
f10989c
Compare
Is this still needed or did your latest changes address this? |
My last changed adress it |
Hello @jourdain, I found my mistake I didn't pass
|
Glad you figure it out... Sorry I could not provide much help. I'm off till the end of the week. |
supersede: #1070
Remaining tasks:
VTKJS
(to load vtkjs files)VTKSynchronized
to handlevtk
render windowFuture tasks (in an other PR)
VTKSynchronized
pane@philippjfr I think the PR is ready for review, everithing should almost work as before.
There are some small API breaks (for colorbars and mostly on javascript side)
I'll make more doc improvement in an other PR