Possible fixes for example packaging #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=========================================
- Coverage 89.91% 89.81% -0.1%
=========================================
Files 30 30
Lines 4758 4763 +5
=========================================
Hits 4278 4278
- Misses 480 485 +5
Continue to review full report at Codecov.
|
philippjfr
reviewed
Dec 5, 2018
|
|
||
| example_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), | ||
| 'panel','examples') | ||
| if 'develop' not in sys.argv: |
There was a problem hiding this comment.
Don't really get this, develop installs the project in place which means you're basically just copying the files to the same location.
There was a problem hiding this comment.
Sorry my mistake, missed the not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix issue where the examples aren't in the package and
panel examplesisn't working.