Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone table formatters and editors #2453

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 29, 2021

Avoids issues with models being used multiple times

Fixes #2307

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #2453 (cab22ae) into master (c80db0d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2453      +/-   ##
==========================================
+ Coverage   83.39%   83.42%   +0.03%     
==========================================
  Files         182      183       +1     
  Lines       22739    22786      +47     
==========================================
+ Hits        18963    19010      +47     
  Misses       3776     3776              
Impacted Files Coverage Δ
panel/tests/widgets/test_tables.py 99.30% <100.00%> (+<0.01%) ⬆️
panel/util.py 82.97% <100.00%> (+0.22%) ⬆️
panel/widgets/tables.py 83.66% <100.00%> (+0.09%) ⬆️
panel/widgets/ace.py 100.00% <0.00%> (ø)
panel/tests/io/test_save.py 100.00% <0.00%> (ø)
panel/io/resources.py 76.23% <0.00%> (+0.49%) ⬆️
panel/io/save.py 59.82% <0.00%> (+2.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80db0d...cab22ae. Read the comment docs.

@philippjfr philippjfr merged commit 406e6c0 into master Jun 29, 2021
@philippjfr philippjfr deleted the column_formatter_clone branch June 29, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make copies of user provided Bokeh models
1 participant