Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users if extension is not loaded before server page is rendered #2766

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

philippjfr
Copy link
Member

Fixes #2765

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #2766 (0624e23) into master (6a9e254) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   82.75%   82.73%   -0.03%     
==========================================
  Files         188      188              
  Lines       24095    24100       +5     
==========================================
- Hits        19940    19939       -1     
- Misses       4155     4161       +6     
Impacted Files Coverage Δ
panel/pane/deckgl.py 73.18% <ø> (ø)
panel/widgets/ace.py 100.00% <ø> (ø)
panel/widgets/tables.py 85.35% <ø> (ø)
panel/widgets/terminal.py 75.00% <ø> (ø)
panel/util.py 81.52% <28.57%> (-1.27%) ⬇️
panel/pane/echarts.py 77.58% <100.00%> (ø)
panel/pane/equation.py 85.41% <100.00%> (ø)
panel/pane/perspective.py 54.14% <100.00%> (ø)
panel/pane/plotly.py 84.98% <100.00%> (ø)
panel/pane/vega.py 82.64% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9e254...0624e23. Read the comment docs.

@philippjfr philippjfr merged commit c40c16b into master Sep 21, 2021
@philippjfr philippjfr deleted the server_notify_extension branch September 21, 2021 16:47
philippjfr added a commit that referenced this pull request Sep 24, 2021
…2766)

* Warn users if extension is not loaded before server page is rendered

* cleanup

* Fix flakes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier for new users - Raise warning or error if extension not imported
1 participant