Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring Vega output #2846

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Add support for configuring Vega output #2846

merged 2 commits into from
Nov 4, 2021

Conversation

philippjfr
Copy link
Member

Should consider which other VegaEmbed options to expose or whether to simply let users provide a config dictionary.

Implements #2821

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #2846 (dd196ae) into master (8dfb3e9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head dd196ae differs from pull request most recent head 69f2c4c. Consider uploading reports for the commit 69f2c4c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2846      +/-   ##
==========================================
+ Coverage   83.04%   83.06%   +0.02%     
==========================================
  Files         190      188       -2     
  Lines       24554    24454     -100     
==========================================
- Hits        20390    20313      -77     
+ Misses       4164     4141      -23     
Impacted Files Coverage Δ
panel/models/vega.py 94.11% <100.00%> (+0.78%) ⬆️
panel/pane/vega.py 82.92% <100.00%> (+0.13%) ⬆️
panel/auth.py 39.15% <0.00%> (-1.65%) ⬇️
panel/util.py 81.52% <0.00%> (-1.21%) ⬇️
panel/param.py 87.63% <0.00%> (-0.05%) ⬇️
panel/pane/markup.py 97.19% <0.00%> (-0.04%) ⬇️
panel/tests/test_param.py 99.87% <0.00%> (-0.01%) ⬇️
panel/config.py 58.95% <0.00%> (ø)
panel/widgets/ace.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfb3e9...69f2c4c. Read the comment docs.

@philippjfr philippjfr merged commit 013ab50 into master Nov 4, 2021
@philippjfr philippjfr deleted the vega_config branch November 4, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant