Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Tabulator styles handling #3175

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Redesign Tabulator styles handling #3175

merged 2 commits into from
Feb 4, 2022

Conversation

philippjfr
Copy link
Member

Previously we were resetting the styles property on the model and keeping a local copy on the view. The problem with this is that the same model can be rendered again at a later stage and if when it was deleted the styles had been reset then it would render without the styles the second time. Therefore we take the simpler approach of including a random id in the styles so that even when the style hasn't changed it will still trigger updates.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #3175 (8222ae2) into master (3768a17) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3175   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files         192      192           
  Lines       25520    25521    +1     
=======================================
+ Hits        21168    21169    +1     
  Misses       4352     4352           
Impacted Files Coverage Δ
panel/models/tabulator.py 95.45% <100.00%> (ø)
panel/tests/widgets/test_tables.py 99.49% <100.00%> (ø)
panel/widgets/tables.py 84.78% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3768a17...8222ae2. Read the comment docs.

@philippjfr philippjfr merged commit c24e28f into master Feb 4, 2022
@philippjfr philippjfr deleted the tabulator_styles branch February 4, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant