add spinner widget #368
Merged
add spinner widget #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xavArtley
commented
Apr 4, 2019
xavArtley
commented
philippjfr
reviewed
Apr 10, 2019
panel/widgets/input.py
Outdated
| @@ -129,6 +129,25 @@ class ColorPicker(Widget): | |||
| _rename = {'value': 'color', 'name': 'title'} | |||
|
|
|||
|
|
|||
| class Spinner(Widget): | |||
|
|
|||
| low = param.Number(default=None, doc=""" | |||
There was a problem hiding this comment.
Let's make these consistent with other similar widgets and call them start and end.
|
Looks great thanks, one minor comment otherwise I'm happy to merge. |
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 86.63% 86.64% +0.01%
==========================================
Files 92 92
Lines 7884 7891 +7
==========================================
+ Hits 6830 6837 +7
Misses 1054 1054
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.