V0.7.0 doc updates #768
Merged
V0.7.0 doc updates #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
approved these changes
Nov 13, 2019
| @@ -169,14 +228,14 @@ | |||
| "metadata": {}, | |||
| "outputs": [], | |||
| "source": [ | |||
| "#sine_panel.show()" | |||
| "#occupancy.show()" | |||
There was a problem hiding this comment.
Hmm. I wonder if we shouldn't use some more generic name here, because I expect that lots of people will use this file as an example. Notice how we had to change "sine_panel" to "occupancy", and users writing their own examples are likely to have to do the same (inviting typing errors) or leave the old name (confusing themselves and readers). Maybe we could call it "row" or "panel" or "app"?
There was a problem hiding this comment.
There's like three versions of the app in this notebook, not clear to me which to rename, whether to reuse names etc. I'll leave it for now.
jbednar
reviewed
Nov 13, 2019
philippjfr
commented
Nov 13, 2019
philippjfr
force-pushed
the
v0.7.0_doc_updates
branch
from
e76b4cf
to
994007b
Compare
Co-Authored-By: James A. Bednar <jbednar@users.noreply.github.com>
philippjfr
force-pushed
the
v0.7.0_doc_updates
branch
from
1fdb8f0
to
3a684a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #754