Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of using Folium in Panel - Notebook for Gallery #1189

Merged
merged 6 commits into from
Apr 3, 2020

Conversation

MarcSkovMadsen
Copy link
Collaborator

Demonstrates the use of Folium in Panel.

This notebook was created as a response to the Panel and Folium do they mix question on Discourse.

panel_folium_example

@MarcSkovMadsen MarcSkovMadsen changed the title added Example of using Folium in Panel - Notebook for Gallery Mar 25, 2020
@MarcSkovMadsen
Copy link
Collaborator Author

See also https://twitter.com/MarcSkovMadsen/status/1242896463635591168

Share if you like.

@philippjfr
Copy link
Member

Thanks, nice how easy this is. Could you either add folium to the test dependencies in setup.py or put a regex to skip testing the notebook at the end of the tox.ini?

@MarcSkovMadsen
Copy link
Collaborator Author

I've added Folium to the test requirements @philippjfr

image

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #1189 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   87.43%   87.44%           
=======================================
  Files         106      106           
  Lines       12627    12632    +5     
=======================================
+ Hits        11041    11046    +5     
  Misses       1586     1586           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
panel/pane/plot.py 75.26% <100.00%> (+1.40%) ⬆️
panel/viewable.py 77.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e47d2...9947025. Read the comment docs.

@MarcSkovMadsen
Copy link
Collaborator Author

I've shared a tweet. Feel free to share if you like https://twitter.com/MarcSkovMadsen/status/1243405883175911426?s=20

voltage_example

@philippjfr
Copy link
Member

FileNotFoundError: [Errno 2] File sample_data.csv does not exist: 'sample_data.csv'

Seems to be erroring, I also haven't quite decided how to handle sample data files in Panel yet.

@MarcSkovMadsen
Copy link
Collaborator Author

The idea is that the user generates the sample data by clicking the save button.

Will look for a workaround

@philippjfr philippjfr modified the milestones: v1.0.0, v0.9.5 Apr 2, 2020
@philippjfr philippjfr merged commit aa14739 into holoviz:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants