Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug closing Tabs #1208

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Fix bug closing Tabs #1208

merged 2 commits into from
Apr 1, 2020

Conversation

philippjfr
Copy link
Member

Fixes #1188

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #1208 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
- Coverage   87.63%   87.62%   -0.01%     
==========================================
  Files         106      106              
  Lines       12588    12709     +121     
==========================================
+ Hits        11031    11136     +105     
- Misses       1557     1573      +16     
Impacted Files Coverage Δ
panel/layout.py 84.76% <100.00%> (+0.06%) ⬆️
panel/io/save.py 78.37% <0.00%> (-4.06%) ⬇️
panel/io/state.py 89.70% <0.00%> (-0.50%) ⬇️
panel/util.py 88.05% <0.00%> (+2.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b75072...cd05f6d. Read the comment docs.

@philippjfr philippjfr merged commit 2ae14ba into master Apr 1, 2020
@philippjfr philippjfr deleted the tabs_closeable_fix branch April 1, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs dynamic and closable not working
1 participant