-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update guidance about package-lock.json #1220
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1220 +/- ##
=======================================
Coverage 87.41% 87.41%
=======================================
Files 106 106
Lines 12619 12619
=======================================
Hits 11031 11031
Misses 1588 1588 Continue to review full report at Codecov.
|
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@holoviz/panel", | |||
"version": "0.9.4", | |||
"version": "0.9.4-1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest using a full version string like 0.9.4-dev.1
or 0.9.4-rc.1
and publishing with an appropriate tag, i.e. npm publish --access=public --tag=dev
(or --tag=rc
respectively). For production release you can skip --tag
altogether or use --tag=latest
(that's the default).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also version should be kept in package.json
, then npm install
will update package-lock.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this was a build number generated using npm version build
because I messed up the initial release of 0.9.4 and did npm unpublish
, so I wouldn't ordinarily do this. I also realized too late that you can't republish after unpublishing, which means that the currently released Python packages won't be able to load the 0.9.4 release from the CDN :(
Will have to tag a 0.9.5 soon to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(...) can't republish after unpublishing (...)
This used to be possible on npm, but it's so unsafe that it was removed not that long ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's fair enough, although I wish it gave you a 5 minute window or something or until the first person downloaded it.
Merging for now, will reset the version on the next release. |
Closes #739