Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Card and Accordion docs #1267

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Updated Card and Accordion docs #1267

merged 1 commit into from
Apr 14, 2020

Conversation

jbednar
Copy link
Member

@jbednar jbednar commented Apr 14, 2020

Minor clarifications and fixes. It would also be great for the start of these docs to point to a full-fledged running dashboard made out of cards, so that it's clear how to use them together to make a full-page layout.

@jbednar jbednar requested a review from philippjfr April 14, 2020 02:36
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. We'll get those full dashboard examples in my templates PR(s).

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #1267 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1267   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files         117      117           
  Lines       12952    12952           
=======================================
  Hits        11337    11337           
  Misses       1615     1615           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a3398c...9da5c2d. Read the comment docs.

@philippjfr philippjfr merged commit dcfa4c6 into master Apr 14, 2020
@philippjfr philippjfr deleted the accordcard branch April 14, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants