Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default templates #1277

Merged
merged 12 commits into from
May 13, 2020
Merged

Add default templates #1277

merged 12 commits into from
May 13, 2020

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 16, 2020

This PR will add a number of default Templates which allow populating three main areas:

  • Header
  • Sidebar
  • Main area

The templates are built on a choice of different CSS frameworks including:

  • Material Web Components
  • Bootstrap

Material Web Components

Screen Shot 2020-04-17 at 1 16 38 AM

Bootstrap

Screen Shot 2020-05-12 at 4 10 18 PM

@philippjfr philippjfr added the type: enhancement Minor feature or improvement to an existing feature label Apr 17, 2020
@MarcSkovMadsen
Copy link
Collaborator

Going to be nice.

You will get requesst from some people regarding a footer and a title_icon. I guess. I would be needing the title_icon but not the footer personally.

@jbednar
Copy link
Member

jbednar commented Apr 17, 2020

What about a right sidebar? Is there a big cost to having empty Divs when they aren't used?

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #1277 into master will increase coverage by 0.11%.
The diff coverage is 65.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1277      +/-   ##
==========================================
+ Coverage   87.69%   87.80%   +0.11%     
==========================================
  Files         126      130       +4     
  Lines       13590    14076     +486     
==========================================
+ Hits        11918    12360     +442     
- Misses       1672     1716      +44     
Impacted Files Coverage Δ
panel/viewable.py 68.80% <ø> (+0.45%) ⬆️
panel/template/base.py 56.16% <51.37%> (ø)
panel/template/theme.py 72.22% <72.22%> (ø)
panel/io/server.py 37.65% <100.00%> (ø)
panel/layout/card.py 95.74% <100.00%> (+0.09%) ⬆️
panel/template/__init__.py 100.00% <100.00%> (ø)
panel/template/bootstrap/__init__.py 100.00% <100.00%> (ø)
panel/template/material/__init__.py 100.00% <100.00%> (ø)
panel/tests/test_param.py 99.77% <0.00%> (-0.08%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939cd52...60e546d. Read the comment docs.

@philippjfr philippjfr merged commit b73ec77 into master May 13, 2020
@philippjfr philippjfr deleted the default_templates branch May 13, 2020 12:46
philippjfr added a commit that referenced this pull request May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants